[api-documenter] Update regex in the OfficeYamlDocumenter to be case insensitive#5257
Open
AlexJerabek wants to merge 2 commits intomicrosoft:mainfrom
Open
[api-documenter] Update regex in the OfficeYamlDocumenter to be case insensitive#5257AlexJerabek wants to merge 2 commits intomicrosoft:mainfrom
AlexJerabek wants to merge 2 commits intomicrosoft:mainfrom
Conversation
AlexJerabek
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
ElizabethSamuel-MSFT
approved these changes
Jun 20, 2025
Contributor
Author
|
@iclanton @dmichon-msft, any chance for a quick review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes output like what's seen in this yaml file. When the term "Api" is in the description twice, the API set link isn't corrected. In this case, the "ExcelApi" string is also incorrectly changed.
The solution is to combine the case normalization of "Api set" and the link addition.
Details
How it was tested
Manually tested the regex against the source yaml.
Impacted documentation